Skip to content

[Dashboard] Remove phone login option and add info alert #7391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2025
Merged

[Dashboard] Remove phone login option and add info alert #7391

merged 1 commit into from
Jun 20, 2025

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jun 20, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Added an informational alert to notify users that phone login is no longer supported and to use their account email instead, with a link to the support page.

  • Bug Fixes

    • Removed phone as a supported login method from in-app wallet authentication options.

@changeset-bot
Copy link

changeset-bot bot commented Jun 20, 2025

⚠️ No Changeset found

Latest commit: db58022

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 20, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2025 6:29am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Jun 20, 2025 6:29am
login ⬜️ Skipped (Inspect) Jun 20, 2025 6:29am
nebula ⬜️ Skipped (Inspect) Jun 20, 2025 6:29am
thirdweb_playground ⬜️ Skipped (Inspect) Jun 20, 2025 6:29am
wallet-ui ⬜️ Skipped (Inspect) Jun 20, 2025 6:29am

@vercel vercel bot temporarily deployed to Preview – docs-v2 June 20, 2025 06:21 Inactive
@vercel vercel bot temporarily deployed to Preview – login June 20, 2025 06:21 Inactive
@vercel vercel bot temporarily deployed to Preview – nebula June 20, 2025 06:21 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui June 20, 2025 06:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground June 20, 2025 06:21 Inactive
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 20, 2025 •
edited
Loading

Walkthrough

The login page was updated to remove "phone" as a supported login method from the available options. An informational alert was added to inform users that phone login is no longer supported, advising them to use their email and providing a link to the support page.

Changes

File Change Summary
apps/dashboard/src/app/(app)/login/LoginPage.tsx Removed "phone" from login options; added info alert about discontinued phone login method.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant LoginPage
    participant SupportPage

    User ->> LoginPage: Visit login page
    LoginPage -->> User: Display login options (without phone)
    LoginPage -->> User: Show info alert about phone login removal
    User ->> SupportPage: (Optional) Click support link for help
Loading
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6be9459 and db58022.

📒 Files selected for processing (1)
  • apps/dashboard/src/app/(app)/login/LoginPage.tsx (3 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
apps/dashboard/src/app/(app)/login/LoginPage.tsx (1)
apps/dashboard/src/@/components/ui/UnderlineLink.tsx (1)
  • UnderlineLink (6-16)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, webpack)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: Lint Packages
  • GitHub Check: Build Packages
  • GitHub Check: Unit Tests
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
apps/dashboard/src/app/(app)/login/LoginPage.tsx (3)

9-10: LGTM: Import statements are appropriate for the new functionality.

The added imports are necessary and correctly support the new alert component and styling functionality.

Also applies to: 16-16

336-355: Excellent user communication for the phone login removal.

The informational alert is well-implemented with:

  • Clear messaging about the change
  • Helpful guidance to use email instead
  • Proper semantic structure with AlertTitle and AlertDescription
  • Support link for users who need assistance
  • Appropriate visual styling with info variant and phone icon

The placement after the ConnectEmbed component with proper spacing ensures good visibility without disrupting the login flow.

45-45: ```shell
#!/bin/bash
echo "Searching for 'phone' references across .ts and .tsx files..."
rg -g '.ts' -g '.tsx' -i '"phone"' -C2

echo -e "\nSearching for auth.phone and phone.auth..."
rg -g '.ts' -g '.tsx' -i 'auth.*phone|phone.*auth' -C3

echo -e "\nSearching for wallet.phone and phone.wallet..."
rg -g '.ts' -g '.tsx' -i 'wallet.*phone|phone.*wallet' -C3


</details>

</blockquote></details>

</details>
<!-- internal state start -->


<!-- DwQgtGAEAqAWCWBnSTIEMB26CuAXA9mAOYCmGJATmriQCaQDG+Ats2bgFyQAOFk+AIwBWJBrngA3EsgEBPRvlqU0AgfFwA6NPEgQAfACgjoCEYDEZyAAUASpETZWaCrKNwSPbABsvkCiQBHbGlcSHFcLzpIACIAbQARNERYAXxnWgBdSBsSZnwpHlh8ckgvfCJ4LHxucWL0DHo0WnpKgDN8dEiKXGjIAHck+2wBZnUaejkw2A9sREpIIQxEWi9kQdtIDEcBeYB2AGYATgBGDRhpxlhMUmRKiXwvAv88iUqiKY9uIpKyiqqa+B1VoUFgfSC0JIpNIURoNdDNN71FAYdoUZjUQEYNC+bGUTTnDwbVBFRDjfhYXAXSnwGF9EgCMBKCQAeiEyH83HwiHU+Bc9XoDEwkB26AYDGkc0aoVguFw3EQHGZzIqlOGGiYzGZ1Np9MZJBZbOZ3G8XmZBxOGnMlgAwiw2BhcMgHE4XG4Lhr7Y7yVNUMafH5AsFSTwKPB0aGvPJePl4EpkaSKNgxJi1nC2rz0bUsP4vNQogQwQBxKhfdQeACylFIkAAisFgvZZKTcpBZlFUZB0Vi/u82BQbsifeySJzuQQXGd3K25nxFstVpASAAPbi5yrIIp9MIdNtFksIGiQSv9jx1kgNyZNWiIxDcUTwVrwBilFQkBcFymEmxcaJ90hgIJzxIXoCyvMENg/C4BDQBgAGt+FaME/w8QDggAGn4PhoiKXBHyXXoO2wE8HUgPDpCmah7CKbx6EQWD4G4MFUI8TAJg8ZD6HIJd8QASVCVAMHwMlKUotBIGLNBS0PGCmGwEjUH8IIaXzHc5iHTsqxQ+sSAwvp1FgdB7HgIgMDAbBGK8Sp4OjV4lFoS0DAAQSqftMHgAAvDE6iaUYsCuZAyBUSJ6E/cT9zLI9NNrbTSN5dSOS5HkXAw1iFAdUMBDwXk1n8eFXklTYhO3DST3BZSxEjUiQWYcT1AACWGdBkFofAbw6PT/X8UlnFCJgHUqbB8FmZEaCIKgs0gAAKa0eIAShDfBxUQOZkDqWxkAYIj/AdSqdkRaMloKyZQuQyBmIcqcPXYNZVg6SoGC8bA438VpKDIJbiokqSWLhbq4LeXSEAYAznA8AgHlTeg2EpRQHnKeByJzPMQo6Ls0B7TxOsDEJwRHMglAwBgEchkqBxIVpHyJ9hI0naZctBwqwlEWAMCfbEysQTblpTTDSJIOhoLg71QqYONgeucjP2YOZHnIvTqQpd07WuhbbLoBz9GMcAoHxhCcAIYgyGUMkrodLheH4YRRHEKQZHkUXlFUdQtB0TWTCgOBUFQIU0Cyw3yHGqJTc4Pw0C3Z1w3kSYHaoJ3NG0XQwEMLXTAMST5WZCFklSdJmUQCgGGZdPmUm9PZuZX5KmZAAZeGMCsdGSA0R0lw4Axog7gwLEgRyeP942ogj5x5HwRDxYwG43Q8Sv/izZAO0qMB0/6bFIlCX3P36wUJquAodjIVtuAhYSOmefIPGiL5imAprDIcbhOW6KIZ40mH6GBUFUkpJDtCwAADGeAB5AExREB/35JAP+lRHIPwAOqrxILgWufxgFz3Ac4KgTYziOQRFmVeshdL6UqGCP+1pZgEGYLaDA5AxAAFFmA7FoOAjUnJyAOhSlgdMaIvJYhxF0aUgx95YCvFEHYZQtyhVIcUGhuB6GMPAQAVR4rTb2/DCriEfORNsFBkAiVCFfH4dcUDIEEqUYopA+D30fmSVKTR8qS2mDVAsu5Pw0lFLJEiuRtC+ALL8Qc64aBNDOHxToiAOg2VjORMSlkMDwUgh4KxvJ9GN1inwJI3JuqEybgSToeJkQPSelEzhfUIGoFJLIYK/R9JImiOmXoEhnDwEwOvOE4Y/jC2qGcAAch0ISdNLgS10R0Suz44p9VwCCXwrRxH9Dep2JoTcjBWh7l4Gg40ebxNxg9ZwPDVqIWXNYqIcVjQCEss+dg6hiZGCgD0gZE9JYdFCtyEy1AiLkTikobZ6zQF6wOUko5fATlnMXP1cQcs5noiUJaDu0RrlJxTjrOEo99aEFIAHZGChWDsC4FQcOjhI7CntooR2ah46u3he7TFoxcAAH1YyIBpf4V4JA6S0Bpd1boidk6UtoAIAArAADgAAwACYRUkGOMKtAIrBStBUAANiFQAFkOAwEV8qlXyvFbsCV5M0DSp2LsLlCKqXqDpbQBlTKEasppbrfQQA=== -->

<!-- internal state end -->
<!-- finishing_touch_checkbox_start -->

<details open="true">
<summary>✨ Finishing Touches</summary>

- [ ] <!-- {"checkboxId": "7962f53c-55bc-4827-bfbf-6a18da830691"} --> 📝 Generate Docstrings

</details>

<!-- finishing_touch_checkbox_end -->
<!-- tips_start -->

---



<details>
<summary>🪧 Tips</summary>

### Chat

There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=thirdweb-dev/js&utm_content=7391):

- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  - `I pushed a fix in commit <commit_id>, please review it.`
  - `Explain this complex logic.`
  - `Open a follow-up GitHub issue for this discussion.`
- Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples:
  - `@coderabbitai explain this code block.`
  -	`@coderabbitai modularize this function.`
- PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.`
  - `@coderabbitai read src/utils.ts and explain its main purpose.`
  - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.`
  - `@coderabbitai help me debug CodeRabbit configuration file.`

### Support

Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

### CodeRabbit Commands (Invoked using PR comments)

- `@coderabbitai pause` to pause the reviews on a PR.
- `@coderabbitai resume` to resume the paused reviews.
- `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
- `@coderabbitai full review` to do a full review from scratch and review all the files again.
- `@coderabbitai summary` to regenerate the summary of the PR.
- `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR.
- `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR.
- `@coderabbitai resolve` resolve all the CodeRabbit review comments.
- `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository.
- `@coderabbitai help` to get help.

### Other keywords and placeholders

- Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed.
- Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description.
- Add `@coderabbitai` anywhere in the PR title to generate the title automatically.

### CodeRabbit Configuration File (`.coderabbit.yaml`)

- You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository.
- Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json`

### Documentation and Community

- Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit.
- Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback.
- Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

</details>

<!-- tips_end -->

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Jun 20, 2025
@jnsdls jnsdls marked this pull request as ready for review June 20, 2025 06:21
@jnsdls Graphite App
Copy link
Member Author

jnsdls commented Jun 20, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls requested review from a team as code owners June 20, 2025 06:22
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 62.53 KB (0%) 1.3 s (0%) 646 ms (+44.36% 🔺) 1.9 s
thirdweb (cjs) 350.55 KB (0%) 7.1 s (0%) 3.5 s (+2.09% 🔺) 10.6 s
thirdweb (minimal + tree-shaking) 5.7 KB (0%) 114 ms (0%) 225 ms (+708.33% 🔺) 339 ms
thirdweb/chains (tree-shaking) 531 B (0%) 11 ms (0%) 74 ms (+842.53% 🔺) 85 ms
thirdweb/react (minimal + tree-shaking) 19.59 KB (0%) 392 ms (0%) 211 ms (+283.99% 🔺) 602 ms

@jnsdls jnsdls merged commit f56cc00 into main Jun 20, 2025
24 of 25 checks passed
@jnsdls jnsdls deleted the _Dashboard_Remove_phone_login_option_and_add_info_alert branch June 20, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arcoraven arcoraven arcoraven approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jnsdls jnsdls

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsdls @arcoraven